OSDN Git Service

fm10k: demote BUG_ON() to WARN_ON() where appropriate
authorBruce Allan <bruce.w.allan@intel.com>
Tue, 22 Dec 2015 22:55:20 +0000 (14:55 -0800)
committerJeff Kirsher <jeffrey.t.kirsher@intel.com>
Tue, 5 Apr 2016 19:44:36 +0000 (12:44 -0700)
We don't need to crash the kernel in this instance so just warn about the
condition and play on.

Signed-off-by: Bruce Allan <bruce.w.allan@intel.com>
Tested-by: Krishneil Singh <Krishneil.k.singh@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
drivers/net/ethernet/intel/fm10k/fm10k_pci.c

index c9324c7..60a70e9 100644 (file)
@@ -99,7 +99,7 @@ void fm10k_service_event_schedule(struct fm10k_intfc *interface)
 
 static void fm10k_service_event_complete(struct fm10k_intfc *interface)
 {
-       BUG_ON(!test_bit(__FM10K_SERVICE_SCHED, &interface->state));
+       WARN_ON(!test_bit(__FM10K_SERVICE_SCHED, &interface->state));
 
        /* flush memory to make sure state is correct before next watchog */
        smp_mb__before_atomic();