OSDN Git Service

wil6210: remove leftover "FIXME"s
authorDedy Lansky <qca_dlansky@qca.qualcomm.com>
Thu, 14 Dec 2017 16:53:12 +0000 (18:53 +0200)
committerKalle Valo <kvalo@codeaurora.org>
Tue, 9 Jan 2018 08:03:33 +0000 (10:03 +0200)
"FIXME: IRQ mask debug" and "FIXME: interrupts enabled - for debug"
can be removed because wil6210_debug_irq_mask() is now considered
production feature.

"FIXME FW can transmit only ucast frames to peer" and "FIXME real
ring_id instead of hard coded 0" can be removed because FW/HW already
support multicast transmission.

Signed-off-by: Dedy Lansky <qca_dlansky@qca.qualcomm.com>
Signed-off-by: Maya Erez <qca_merez@qca.qualcomm.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
drivers/net/wireless/ath/wil6210/interrupt.c
drivers/net/wireless/ath/wil6210/wil6210.h
drivers/net/wireless/ath/wil6210/wmi.c

index 5cf3417..dcf87a7 100644 (file)
@@ -565,7 +565,7 @@ static irqreturn_t wil6210_hardirq(int irq, void *cookie)
        if (unlikely((pseudo_cause == 0) || ((pseudo_cause & 0xff) == 0xff)))
                return IRQ_NONE;
 
-       /* FIXME: IRQ mask debug */
+       /* IRQ mask debug */
        if (unlikely(wil6210_debug_irq_mask(wil, pseudo_cause)))
                return IRQ_NONE;
 
index 138df71..da0b28c 100644 (file)
@@ -439,7 +439,7 @@ enum { /* for wil6210_priv.status */
        wil_status_fwconnected,
        wil_status_dontscan,
        wil_status_mbox_ready, /* MBOX structures ready */
-       wil_status_irqen, /* FIXME: interrupts enabled - for debug */
+       wil_status_irqen, /* interrupts enabled - for debug */
        wil_status_napi_en, /* NAPI enabled protected by wil->mutex */
        wil_status_resetting, /* reset in progress */
        wil_status_suspending, /* suspend in progress */
index d06090d..9b9882c 100644 (file)
@@ -813,8 +813,6 @@ static void wmi_evt_connect(struct wil6210_priv *wil, int id, void *d, int len)
                }
        }
 
-       /* FIXME FW can transmit only ucast frames to peer */
-       /* FIXME real ring_id instead of hard coded 0 */
        ether_addr_copy(wil->sta[evt->cid].addr, evt->bssid);
        wil->sta[evt->cid].status = wil_sta_conn_pending;