OSDN Git Service

i3c: fix an error code in i3c_master_add_i3c_dev_locked()
authorDan Carpenter <dan.carpenter@oracle.com>
Fri, 23 Nov 2018 07:14:42 +0000 (10:14 +0300)
committerBoris Brezillon <boris.brezillon@bootlin.com>
Wed, 5 Dec 2018 16:22:58 +0000 (17:22 +0100)
We should return "ret" as-is.  The "newdev" variable is a valid pointer.

Fixes: 3a379bbcea0a ("i3c: Add core I3C infrastructure")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>
drivers/i3c/master.c

index 0ea7bb0..bda4b96 100644 (file)
@@ -1823,10 +1823,8 @@ int i3c_master_add_i3c_dev_locked(struct i3c_master_controller *master,
                return PTR_ERR(newdev);
 
        ret = i3c_master_attach_i3c_dev(master, newdev);
-       if (ret) {
-               ret = PTR_ERR(newdev);
+       if (ret)
                goto err_free_dev;
-       }
 
        ret = i3c_master_retrieve_dev_info(newdev);
        if (ret)