OSDN Git Service

don't hardcode compilation options based on product/target names
authorBrian Swetland <swetland@google.com>
Sat, 27 Dec 2008 01:36:56 +0000 (17:36 -0800)
committerBrian Swetland <swetland@google.com>
Sat, 27 Dec 2008 01:36:56 +0000 (17:36 -0800)
This provides a way for board files to specify libraries/flags for
hardware codecs, etc, though really this should not require compile
time options -- somebody who understands opencore should fix it to
deal with this gracefully at runtime.

This fixes the htc_dream build.

android/author/Android.mk
codecs_v2/omx/omx_common/Android.mk
pvauthor/Android.mk
pvcommon/Android.mk
pvplayer/Android.mk

index 8f107c0..0910aeb 100644 (file)
@@ -13,9 +13,8 @@ LOCAL_SRC_FILES := \
 
 LOCAL_CFLAGS := $(PV_CFLAGS)
 
-ifeq ($(TARGET_DEVICE),dream)
-LOCAL_CFLAGS += -DHARDWARE_OMX=1
-endif
+# board-specific configuration
+LOCAL_CFLAGS += $(BOARD_OPENCORE_FLAGS)
 
 LOCAL_ARM_MODE := arm
 
index 463fa13..9926d2b 100755 (executable)
@@ -14,9 +14,8 @@ LOCAL_MODULE := libomx_common_lib
 
 LOCAL_CFLAGS :=   $(PV_CFLAGS)
 
-ifeq ($(TARGET_DEVICE),dream)
-LOCAL_CFLAGS += -DHARDWARE_OMX=1
-endif
+# board-specific configuration
+LOCAL_CFLAGS += $(BOARD_OPENCORE_FLAGS)
 
 LOCAL_ARM_MODE := arm
 
index 50f7bf3..c823602 100644 (file)
@@ -27,11 +27,8 @@ ifneq ($(TARGET_SIMULATOR),true)
 LOCAL_SHARED_LIBRARIES += libdl
 endif
 
-# Include Qualcomm codec
-ifeq ($(TARGET_DEVICE),dream)
-LOCAL_SHARED_LIBRARIES += libOmxCore
-endif
-
+# Include board-specific extensions
+LOCAL_SHARED_LIBRARIES += $(BOARD_OPENCORE_LIBRARIES)
 
 LOCAL_MODULE := libopencoreauthor
 
index c3fffb6..2cc646e 100644 (file)
@@ -33,10 +33,8 @@ ifneq ($(TARGET_SIMULATOR),true)
 LOCAL_SHARED_LIBRARIES += libdl
 endif
 
-# Include Qualcomm codec
-ifeq ($(TARGET_DEVICE),dream)
-LOCAL_SHARED_LIBRARIES += libOmxCore
-endif
+# Include board-specific extensions
+LOCAL_SHARED_LIBRARIES += $(BOARD_OPENCORE_LIBRARIES)
 
 
 LOCAL_MODULE := libopencorecommon
index dc8bdca..69d952d 100644 (file)
@@ -61,10 +61,8 @@ ifneq ($(TARGET_SIMULATOR),true)
 LOCAL_SHARED_LIBRARIES += libdl
 endif
 
-# Include Qualcomm codec
-ifeq ($(TARGET_DEVICE),dream)
-LOCAL_SHARED_LIBRARIES += libOmxCore
-endif
+# Include board-specific extensions
+LOCAL_SHARED_LIBRARIES += $(BOARD_OPENCORE_LIBRARIES)
 
 
 LOCAL_MODULE := libopencoreplayer