OSDN Git Service

tcg/sparc: Make direct jump patching thread-safe
authorSergey Fedorov <serge.fdrv@gmail.com>
Fri, 22 Apr 2016 16:08:51 +0000 (19:08 +0300)
committerRichard Henderson <rth@twiddle.net>
Fri, 13 May 2016 00:06:41 +0000 (14:06 -1000)
Ensure direct jump patching in SPARC is atomic by using
atomic_read()/atomic_set() for code patching.

Signed-off-by: Sergey Fedorov <serge.fdrv@gmail.com>
Signed-off-by: Sergey Fedorov <sergey.fedorov@linaro.org>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <1461341333-19646-10-git-send-email-sergey.fedorov@linaro.org>
Signed-off-by: Richard Henderson <rth@twiddle.net>
tcg/sparc/tcg-target.inc.c

index d641cfd..c6479e2 100644 (file)
@@ -1647,6 +1647,6 @@ void tb_set_jmp_target1(uintptr_t jmp_addr, uintptr_t addr)
        the code_gen_buffer can't be larger than 2GB.  */
     tcg_debug_assert(disp == (int32_t)disp);
 
-    *ptr = CALL | (uint32_t)disp >> 2;
+    atomic_set(ptr, deposit32(CALL, 0, 30, disp >> 2));
     flush_icache_range(jmp_addr, jmp_addr + 4);
 }