OSDN Git Service

RankingHelper: Remove STOPSHIP
authorChristoph Studer <chstuder@google.com>
Wed, 8 Oct 2014 18:19:55 +0000 (11:19 -0700)
committerChristoph Studer <chstuder@google.com>
Wed, 3 Dec 2014 14:12:02 +0000 (15:12 +0100)
Remove obsolete debugging code that was marked STOPSHIP.

Bug: 17919719
Change-Id: I025410c191960382486456c9edd7675a14f0fa4b

services/core/java/com/android/server/notification/RankingHelper.java

index aeddecb..6a96f85 100644 (file)
@@ -227,23 +227,8 @@ public class RankingHelper implements RankingConfig {
             notificationList.get(i).setGlobalSortKey(null);
         }
 
-        try {
-            // rank each record individually
-            Collections.sort(notificationList, mPreliminaryComparator);
-        } catch (RuntimeException ex) {
-            // Don't crash the system server if something bad happened.
-            Log.e(TAG, "Extreme badness during notification sort", ex);
-            Log.e(TAG, "Current notification list: ");
-            for (int i = 0; i < N; i++) {
-                NotificationRecord nr = notificationList.get(i);
-                Log.e(TAG, String.format(
-                        "  [%d] %s (group %s, rank %d, sortkey %s)",
-                        i, nr, nr.getGroupKey(), nr.getAuthoritativeRank(),
-                        nr.getNotification().getSortKey()));
-            }
-            // STOPSHIP: remove once b/16626175 is found
-            throw ex;
-        }
+        // rank each record individually
+        Collections.sort(notificationList, mPreliminaryComparator);
 
         synchronized (mProxyByGroupTmp) {
             // record individual ranking result and nominate proxies for each group