OSDN Git Service

spi: omap-100k: Clean the value of 'status' is not used
authorJay Fang <f.fangjian@huawei.com>
Mon, 10 May 2021 06:58:21 +0000 (14:58 +0800)
committerMark Brown <broonie@kernel.org>
Mon, 10 May 2021 12:07:51 +0000 (13:07 +0100)
An error code is set to 'status' before exiting list_for_each_entry()
loop, but the value of 'status' is not used as below:

  list_for_each_entry(t, &m->transfers, transfer_list) {
   if (t->tx_buf == NULL && t->rx_buf == NULL && t->len) {
   status = -EINVAL;
   break;
   }
   ...
  }

  status = omap1_spi100k_setup_transfer(spi, NULL);

Signed-off-by: Jay Fang <f.fangjian@huawei.com>
Link: https://lore.kernel.org/r/1620629903-15493-3-git-send-email-f.fangjian@huawei.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-omap-100k.c

index 7062f29..dc9b86b 100644 (file)
@@ -296,7 +296,6 @@ static int omap1_spi100k_transfer_one_message(struct spi_master *master,
 
        list_for_each_entry(t, &m->transfers, transfer_list) {
                if (t->tx_buf == NULL && t->rx_buf == NULL && t->len) {
-                       status = -EINVAL;
                        break;
                }
                status = omap1_spi100k_setup_transfer(spi, t);
@@ -315,7 +314,6 @@ static int omap1_spi100k_transfer_one_message(struct spi_master *master,
                        m->actual_length += count;
 
                        if (count != t->len) {
-                               status = -EIO;
                                break;
                        }
                }