OSDN Git Service

mm: compaction: clean up comment about suitable migration target recheck
authorMiaohe Lin <linmiaohe@huawei.com>
Fri, 29 Apr 2022 06:16:17 +0000 (23:16 -0700)
committerakpm <akpm@linux-foundation.org>
Fri, 29 Apr 2022 06:16:17 +0000 (23:16 -0700)
checked_pageblock is already removed and suitable_migration_target is not
rechecked under the zone lock since commit f8224aa5a0a4 ("mm, compaction:
do not recheck suitable_migration_target under lock").  Correct the
comment accordingly.

Link: https://lkml.kernel.org/r/20220418141253.24298-6-linmiaohe@huawei.com
Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
Cc: Charan Teja Kalla <charante@codeaurora.org>
Cc: David Hildenbrand <david@redhat.com>
Cc: Pintu Kumar <pintu@codeaurora.org>
Cc: Vlastimil Babka <vbabka@suse.cz>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
mm/compaction.c

index e839b26..97821b7 100644 (file)
@@ -599,13 +599,7 @@ static unsigned long isolate_freepages_block(struct compact_control *cc,
                if (!PageBuddy(page))
                        goto isolate_fail;
 
-               /*
-                * If we already hold the lock, we can skip some rechecking.
-                * Note that if we hold the lock now, checked_pageblock was
-                * already set in some previous iteration (or strict is true),
-                * so it is correct to skip the suitable migration target
-                * recheck as well.
-                */
+               /* If we already hold the lock, we can skip some rechecking. */
                if (!locked) {
                        locked = compact_lock_irqsave(&cc->zone->lock,
                                                                &flags, cc);