OSDN Git Service

PCI: Drop of_match_ptr() to avoid unused variables
authorBjorn Helgaas <bhelgaas@google.com>
Wed, 16 Nov 2022 20:50:59 +0000 (14:50 -0600)
committerBjorn Helgaas <bhelgaas@google.com>
Thu, 17 Nov 2022 19:32:21 +0000 (13:32 -0600)
We have stubs for most OF interfaces even when CONFIG_OF is not set, so we
allow building of most controller drivers in that case for compile testing.

When CONFIG_OF is not set, "of_match_ptr(<match_table>)" compiles to NULL,
which leaves <match_table> unused, resulting in errors like this:

  $ make W=1
  drivers/pci/controller/pci-xgene.c:636:34: error: ‘xgene_pcie_match_table’ defined but not used [-Werror=unused-const-variable=]

Drop of_match_ptr() to avoid the unused variable warning.

See also 1dff012f636d ("PCI: Drop of_match_ptr() to avoid unused
variables").

Link: https://lore.kernel.org/r/20221025191339.667614-2-helgaas@kernel.org
Link: https://lore.kernel.org/r/20221116205100.1136224-2-helgaas@kernel.org
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
drivers/pci/controller/pci-ftpci100.c
drivers/pci/controller/pci-v3-semi.c

index 0cfd9d5..ecd3009 100644 (file)
@@ -553,7 +553,7 @@ static const struct of_device_id faraday_pci_of_match[] = {
 static struct platform_driver faraday_pci_driver = {
        .driver = {
                .name = "ftpci100",
-               .of_match_table = of_match_ptr(faraday_pci_of_match),
+               .of_match_table = faraday_pci_of_match,
                .suppress_bind_attrs = true,
        },
        .probe  = faraday_pci_probe,
index 784fcf3..ca44b0c 100644 (file)
@@ -901,7 +901,7 @@ static const struct of_device_id v3_pci_of_match[] = {
 static struct platform_driver v3_pci_driver = {
        .driver = {
                .name = "pci-v3-semi",
-               .of_match_table = of_match_ptr(v3_pci_of_match),
+               .of_match_table = v3_pci_of_match,
                .suppress_bind_attrs = true,
        },
        .probe  = v3_pci_probe,