OSDN Git Service

ASoC: dapm: Initialize private_value in snd_soc_dapm_new_dai
authorPankaj Bharadiya <pankaj.laxminarayan.bharadiya@intel.com>
Fri, 22 Mar 2019 16:23:39 +0000 (21:53 +0530)
committerMark Brown <broonie@kernel.org>
Mon, 25 Mar 2019 15:53:06 +0000 (15:53 +0000)
In case of single config, private_value is left uninitialized.

The private_value does need to be initialized or in
snd_soc_dapm_new_control_unlocked() call failure case, it leads to a
bogus free in snd_soc_dapm_free_kcontrol()

Signed-off-by: Pankaj Bharadiya <pankaj.laxminarayan.bharadiya@intel.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/soc-dapm.c

index 1ec06ef..74a6f57 100644 (file)
@@ -4038,7 +4038,7 @@ snd_soc_dapm_new_dai(struct snd_soc_card *card, struct snd_soc_pcm_runtime *rtd,
        struct snd_soc_dapm_widget template;
        struct snd_soc_dapm_widget *w;
        const char **w_param_text;
-       unsigned long private_value;
+       unsigned long private_value = 0;
        char *link_name;
        int ret;