OSDN Git Service

s390/dasd: remove dasd_fba_probe() wrapper
authorJulian Wiedmann <jwi@linux.ibm.com>
Tue, 16 Mar 2021 09:45:12 +0000 (10:45 +0100)
committerJens Axboe <axboe@kernel.dk>
Tue, 16 Mar 2021 14:31:00 +0000 (08:31 -0600)
commit e03c5941f904 ("s390/dasd: Remove unused parameter from
dasd_generic_probe()") allows us to wire the generic callback up
directly, avoiding the additional level of indirection.

While at it also remove the forward declaration for the dasd_fba_driver
struct, it's no longer needed.

Signed-off-by: Julian Wiedmann <jwi@linux.ibm.com>
Reviewed-by: Jan Hoeppner <hoeppner@linux.ibm.com>
Signed-off-by: Stefan Haberland <sth@linux.ibm.com>
Link: https://lore.kernel.org/r/20210316094513.2601218-2-sth@linux.ibm.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/s390/block/dasd_fba.c

index 1aeb687..f76fe05 100644 (file)
@@ -54,13 +54,6 @@ static struct ccw_device_id dasd_fba_ids[] = {
 
 MODULE_DEVICE_TABLE(ccw, dasd_fba_ids);
 
-static struct ccw_driver dasd_fba_driver; /* see below */
-static int
-dasd_fba_probe(struct ccw_device *cdev)
-{
-       return dasd_generic_probe(cdev);
-}
-
 static int
 dasd_fba_set_online(struct ccw_device *cdev)
 {
@@ -73,7 +66,7 @@ static struct ccw_driver dasd_fba_driver = {
                .owner  = THIS_MODULE,
        },
        .ids         = dasd_fba_ids,
-       .probe       = dasd_fba_probe,
+       .probe       = dasd_generic_probe,
        .remove      = dasd_generic_remove,
        .set_offline = dasd_generic_set_offline,
        .set_online  = dasd_fba_set_online,