make finals static, remove unused local

found by findbugs
http://b/issue?id=1856725
http://b/issue?id=1856786

diff --git a/src/com/android/browser/BrowserActivity.java b/src/com/android/browser/BrowserActivity.java
index 0bac3ea..155942e 100644 (file)
--- a/src/com/android/browser/BrowserActivity.java
+++ b/src/com/android/browser/BrowserActivity.java
@@ -290,7 +290,7 @@ public class BrowserActivity extends Activity
         final static String BUILD_INFOS_FILE = "build.prop";
         final static String SYSTEM_BUILD_INFOS_FILE = "/system/"
                               + BUILD_INFOS_FILE;
-        final int BUFSIZE = 4096;
+        final static int BUFSIZE = 4096;
         boolean mDoOverwrite = false;
         String pluginsPath;
         Context mContext;

diff --git a/src/com/android/browser/GearsBaseDialog.java b/src/com/android/browser/GearsBaseDialog.java
index 638ba27..9a56cb8 100644 (file)
--- a/src/com/android/browser/GearsBaseDialog.java
+++ b/src/com/android/browser/GearsBaseDialog.java
@@ -56,7 +56,7 @@ class GearsBaseDialog {
   protected String mDialogArguments;
 
   private Bitmap mIcon;
-  private final int MAX_ICON_SIZE = 64;
+  private static final int MAX_ICON_SIZE = 64;
   protected int mChoosenIconSize;
 
   // Dialog closing types
@@ -341,7 +341,6 @@ class GearsBaseDialog {
         HttpURLConnection connection = (HttpURLConnection) url.openConnection();
         connection.setDoInput(true);
         connection.connect();
-        int length = connection.getContentLength();
         InputStream is = connection.getInputStream();
         Bitmap customIcon = BitmapFactory.decodeStream(is);
         if (customIcon != null) {

diff --git a/src/com/android/browser/GearsNativeDialog.java b/src/com/android/browser/GearsNativeDialog.java
index b44ec2a..192108a 100644 (file)
--- a/src/com/android/browser/GearsNativeDialog.java
+++ b/src/com/android/browser/GearsNativeDialog.java
@@ -52,14 +52,14 @@ public class GearsNativeDialog extends Activity {
   private boolean mDebug = false;
 
   private int mDialogType;
-  private final int SETTINGS_DIALOG = 1;
-  private final int PERMISSION_DIALOG = 2;
-  private final int LOCATION_DIALOG = 3;
-
-  private final String VERSION_STRING = "version";
-  private final String SETTINGS_DIALOG_STRING = "settings_dialog";
-  private final String PERMISSION_DIALOG_STRING = "permissions_dialog";
-  private final String LOCATION_DIALOG_STRING = "locations_dialog";
+  private static final int SETTINGS_DIALOG = 1;
+  private static final int PERMISSION_DIALOG = 2;
+  private static final int LOCATION_DIALOG = 3;
+
+  private static final String VERSION_STRING = "version";
+  private static final String SETTINGS_DIALOG_STRING = "settings_dialog";
+  private static final String PERMISSION_DIALOG_STRING = "permissions_dialog";
+  private static final String LOCATION_DIALOG_STRING = "locations_dialog";
 
   private boolean mDialogDismissed = false;