OSDN Git Service

gpio: omap: irq_shutdown: remove unnecessary call of gpiochip_unlock_as_irq
authorGrygorii Strashko <grygorii.strashko@linaro.org>
Fri, 6 Mar 2015 19:26:56 +0000 (21:26 +0200)
committerLinus Walleij <linus.walleij@linaro.org>
Mon, 9 Mar 2015 17:28:53 +0000 (18:28 +0100)
GPIOLib core implemnts irqchip->irq_request/release_resources callbacks
internally and these callbacks already contain clalls of
gpiochip_lock/unlock_as_irq().

Hence, remove unnecessary call of gpiochip_unlock_as_irq() from
omap_gpio_irq_shutdown().

Signed-off-by: Grygorii Strashko <grygorii.strashko@linaro.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/gpio/gpio-omap.c

index f476ae2..2b2fc4b 100644 (file)
@@ -826,7 +826,6 @@ static void omap_gpio_irq_shutdown(struct irq_data *d)
        unsigned offset = GPIO_INDEX(bank, gpio);
 
        spin_lock_irqsave(&bank->lock, flags);
-       gpiochip_unlock_as_irq(&bank->chip, offset);
        bank->irq_usage &= ~(BIT(offset));
        omap_disable_gpio_module(bank, offset);
        omap_reset_gpio(bank, gpio);