OSDN Git Service

hw/block/nvme: fix legacy namespace registration
authorKlaus Jensen <k.jensen@samsung.com>
Thu, 11 Feb 2021 10:50:19 +0000 (11:50 +0100)
committerKlaus Jensen <k.jensen@samsung.com>
Thu, 11 Feb 2021 13:11:17 +0000 (14:11 +0100)
Moving namespace registration to the nvme-ns realization function had
the unintended side-effect of breaking legacy namespace registration.
Fix this.

Fixes: 15d024d4aa9b ("hw/block/nvme: split setup and register for namespace")
Reported-by: Alexander Graf <agraf@csgraf.de>
Cc: Minwoo Im <minwoo.im.dev@gmail.com>
Tested-by: Alexander Graf <agraf@csgraf.de>
Reviewed-by: Minwoo Im <minwoo.im.dev@gmail.com>
Signed-off-by: Klaus Jensen <k.jensen@samsung.com>
hw/block/nvme.c

index 5ce21b7..02390f1 100644 (file)
@@ -4507,6 +4507,10 @@ static void nvme_realize(PCIDevice *pci_dev, Error **errp)
         if (nvme_ns_setup(ns, errp)) {
             return;
         }
+
+        if (nvme_register_namespace(n, ns, errp)) {
+            return;
+        }
     }
 }