OSDN Git Service

wifi: nl80211: require MLD address on link STA add/modify
authorJohannes Berg <johannes.berg@intel.com>
Tue, 19 Jul 2022 06:44:25 +0000 (08:44 +0200)
committerJohannes Berg <johannes.berg@intel.com>
Fri, 22 Jul 2022 12:28:13 +0000 (14:28 +0200)
We always need the MLD address and link ID to add or
modify the link STA, so require it in the API.

Fixes: 577e5b8c3924 ("wifi: cfg80211: add API to add/modify/remove a link station")
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
net/wireless/nl80211.c

index b6e6404..310d22b 100644 (file)
@@ -15827,14 +15827,13 @@ nl80211_add_mod_link_station(struct sk_buff *skb, struct genl_info *info,
        if (add && !info->attrs[NL80211_ATTR_MAC])
                return -EINVAL;
 
-       if (add && !info->attrs[NL80211_ATTR_MLD_ADDR])
+       if (!info->attrs[NL80211_ATTR_MLD_ADDR])
                return -EINVAL;
 
        if (add && !info->attrs[NL80211_ATTR_STA_SUPPORTED_RATES])
                return -EINVAL;
 
-       if (info->attrs[NL80211_ATTR_MLD_ADDR])
-               params.mld_mac = nla_data(info->attrs[NL80211_ATTR_MLD_ADDR]);
+       params.mld_mac = nla_data(info->attrs[NL80211_ATTR_MLD_ADDR]);
 
        if (info->attrs[NL80211_ATTR_MAC]) {
                params.link_mac = nla_data(info->attrs[NL80211_ATTR_MAC]);