OSDN Git Service

auxdisplay: Remove flag FBINFO_FLAG_DEFAULT from fbdev drivers
authorThomas Zimmermann <tzimmermann@suse.de>
Sat, 15 Jul 2023 18:51:51 +0000 (20:51 +0200)
committerThomas Zimmermann <tzimmermann@suse.de>
Mon, 24 Jul 2023 14:50:39 +0000 (16:50 +0200)
The flag FBINFO_FLAG_DEFAULT is 0 and has no effect, as struct
fbinfo.flags has been allocated to zero by framebuffer_alloc(). So do
not set it.

Flags should signal differences from the default values. After cleaning
up all occurrences of FBINFO_DEFAULT, the token will be removed.

v2:
* fix commit message (Miguel)

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Acked-by: Sam Ravnborg <sam@ravnborg.org>
Acked-by: Miguel Ojeda <ojeda@kernel.org>
Cc: Miguel Ojeda <ojeda@kernel.org>
Cc: Robin van der Gracht <robin@protonic.nl>
Link: https://patchwork.freedesktop.org/patch/msgid/20230715185343.7193-10-tzimmermann@suse.de
drivers/auxdisplay/cfag12864bfb.c
drivers/auxdisplay/ht16k33.c

index c2cab7e..729845b 100644 (file)
@@ -79,7 +79,6 @@ static int cfag12864bfb_probe(struct platform_device *device)
        info->var = cfag12864bfb_var;
        info->pseudo_palette = NULL;
        info->par = NULL;
-       info->flags = FBINFO_FLAG_DEFAULT;
 
        if (register_framebuffer(info) < 0)
                goto fballoced;
index 0c5cd51..3a2d883 100644 (file)
@@ -646,7 +646,6 @@ static int ht16k33_fbdev_probe(struct device *dev, struct ht16k33_priv *priv,
        fbdev->info->var = ht16k33_fb_var;
        fbdev->info->bl_dev = bl;
        fbdev->info->pseudo_palette = NULL;
-       fbdev->info->flags = FBINFO_FLAG_DEFAULT;
        fbdev->info->par = priv;
 
        err = register_framebuffer(fbdev->info);