OSDN Git Service

irqchip/irq-imx-gpcv2: Silence "fall through" warning
authorMarc Zyngier <marc.zyngier@arm.com>
Sat, 15 Dec 2018 09:10:46 +0000 (09:10 +0000)
committerMarc Zyngier <marc.zyngier@arm.com>
Sat, 15 Dec 2018 09:10:46 +0000 (09:10 +0000)
The -Wimplicit-fallthrough option requires that the /* fall through */
comment is placed in the 'case' statement that falls through, rather
than in the following one. Case seems to matter as well.

Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
drivers/irqchip/irq-imx-gpcv2.c

index 17a2dad..d13269c 100644 (file)
@@ -261,7 +261,8 @@ static int __init imx_gpcv2_irqchip_init(struct device_node *node,
                case 4:
                        writel_relaxed(~0, reg + GPC_IMR1_CORE2);
                        writel_relaxed(~0, reg + GPC_IMR1_CORE3);
-               case 2:       /* FALLTHROUGH */
+                       /* fall through */
+               case 2:
                        writel_relaxed(~0, reg + GPC_IMR1_CORE0);
                        writel_relaxed(~0, reg + GPC_IMR1_CORE1);
                }