OSDN Git Service

USB: cp210x: remove useless set memory to zero use memset()
authorWei Yongjun <yongjun_wei@trendmicro.com.cn>
Mon, 27 Aug 2012 07:07:17 +0000 (15:07 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 5 Sep 2012 23:58:30 +0000 (16:58 -0700)
The memory return by kzalloc() or kmem_cache_zalloc() has already
be set to zero, so remove useless memset(0).

spatch with a semantic match is used to found this problem.
(http://coccinelle.lip6.fr/)

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/serial/cp210x.c

index 1e71079..3f86cf3 100644 (file)
@@ -865,7 +865,6 @@ static int cp210x_startup(struct usb_serial *serial)
                if (!port_priv)
                        return -ENOMEM;
 
-               memset(port_priv, 0x00, sizeof(*port_priv));
                port_priv->bInterfaceNumber =
                    serial->interface->cur_altsetting->desc.bInterfaceNumber;