OSDN Git Service

KVM: selftests: Avoid flooding debug log while populating memory
authorBen Gardon <bgardon@google.com>
Tue, 12 Jan 2021 21:42:49 +0000 (13:42 -0800)
committerPaolo Bonzini <pbonzini@redhat.com>
Thu, 4 Feb 2021 10:27:18 +0000 (05:27 -0500)
Peter Xu pointed out that a log message printed while waiting for the
memory population phase of the dirty_log_perf_test will flood the debug
logs as there is no delay after printing the message. Since the message
does not provide much value anyway, remove it.

Reviewed-by: Jacob Xu <jacobhxu@google.com>
Signed-off-by: Ben Gardon <bgardon@google.com>
Message-Id: <20210112214253.463999-3-bgardon@google.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
tools/testing/selftests/kvm/dirty_log_perf_test.c

index 16efe65..15a9c45 100644 (file)
@@ -146,8 +146,7 @@ static void run_test(enum vm_guest_mode mode, void *arg)
        /* Allow the vCPU to populate memory */
        pr_debug("Starting iteration %lu - Populating\n", iteration);
        while (READ_ONCE(vcpu_last_completed_iteration[vcpu_id]) != iteration)
-               pr_debug("Waiting for vcpu_last_completed_iteration == %lu\n",
-                       iteration);
+               ;
 
        ts_diff = timespec_elapsed(start);
        pr_info("Populate memory time: %ld.%.9lds\n",
@@ -171,9 +170,9 @@ static void run_test(enum vm_guest_mode mode, void *arg)
 
                pr_debug("Starting iteration %lu\n", iteration);
                for (vcpu_id = 0; vcpu_id < nr_vcpus; vcpu_id++) {
-                       while (READ_ONCE(vcpu_last_completed_iteration[vcpu_id]) != iteration)
-                               pr_debug("Waiting for vCPU %d vcpu_last_completed_iteration == %lu\n",
-                                        vcpu_id, iteration);
+                       while (READ_ONCE(vcpu_last_completed_iteration[vcpu_id])
+                              != iteration)
+                               ;
                }
 
                ts_diff = timespec_elapsed(start);