OSDN Git Service

net/mlx5e: TC: Remove unused parameter from mlx5_tc_ct_add_no_trk_match()
authorSaeed Mahameed <saeedm@nvidia.com>
Wed, 23 Sep 2020 01:48:04 +0000 (18:48 -0700)
committerSaeed Mahameed <saeedm@nvidia.com>
Wed, 23 Sep 2020 22:44:37 +0000 (15:44 -0700)
priv is never used in this function

Fixes: 7e36feeb0467 ("net/mlx5e: CT: Don't offload tuple rewrites for established tuples")
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
drivers/net/ethernet/mellanox/mlx5/core/en/tc_ct.c
drivers/net/ethernet/mellanox/mlx5/core/en/tc_ct.h
drivers/net/ethernet/mellanox/mlx5/core/en_tc.c

index 9a7bd68..fe78de5 100644 (file)
@@ -1026,9 +1026,7 @@ out:
        return false;
 }
 
-int
-mlx5_tc_ct_add_no_trk_match(struct mlx5e_priv *priv,
-                           struct mlx5_flow_spec *spec)
+int mlx5_tc_ct_add_no_trk_match(struct mlx5_flow_spec *spec)
 {
        u32 ctstate = 0, ctstate_mask = 0;
 
index bab872b..6503b61 100644 (file)
@@ -108,9 +108,7 @@ mlx5_tc_ct_match_add(struct mlx5_tc_ct_priv *priv,
                     struct flow_cls_offload *f,
                     struct mlx5_ct_attr *ct_attr,
                     struct netlink_ext_ack *extack);
-int
-mlx5_tc_ct_add_no_trk_match(struct mlx5e_priv *priv,
-                           struct mlx5_flow_spec *spec);
+int mlx5_tc_ct_add_no_trk_match(struct mlx5_flow_spec *spec);
 int
 mlx5_tc_ct_parse_action(struct mlx5_tc_ct_priv *priv,
                        struct mlx5_flow_attr *attr,
@@ -167,8 +165,7 @@ mlx5_tc_ct_match_add(struct mlx5_tc_ct_priv *priv,
 }
 
 static inline int
-mlx5_tc_ct_add_no_trk_match(struct mlx5e_priv *priv,
-                           struct mlx5_flow_spec *spec)
+mlx5_tc_ct_add_no_trk_match(struct mlx5_flow_spec *spec)
 {
        return 0;
 }
index 4084a29..f815b0c 100644 (file)
@@ -3233,7 +3233,7 @@ static bool modify_header_match_supported(struct mlx5e_priv *priv,
         *  we can't restore ct state
         */
        if (!ct_clear && modify_tuple &&
-           mlx5_tc_ct_add_no_trk_match(priv, spec)) {
+           mlx5_tc_ct_add_no_trk_match(spec)) {
                NL_SET_ERR_MSG_MOD(extack,
                                   "can't offload tuple modify header with ct matches");
                netdev_info(priv->netdev,