OSDN Git Service

dmaengine: xilinx_dma: Clear desc_pendingcount in xilinx_dma_reset
authorNicholas Graumann <nick.graumann@gmail.com>
Tue, 15 Oct 2019 14:48:24 +0000 (20:18 +0530)
committerVinod Koul <vkoul@kernel.org>
Sun, 20 Oct 2019 14:05:27 +0000 (19:35 +0530)
Whenever we reset the channel, we need to clear desc_pendingcount
along with desc_submitcount. Otherwise when a new transaction is
submitted, the irq coalesce level could be programmed to an incorrect
value in the axidma case.

This behavior can be observed when terminating pending transactions
with xilinx_dma_terminate_all() and then submitting new transactions
without releasing and requesting the channel.

Signed-off-by: Nicholas Graumann <nick.graumann@gmail.com>
Signed-off-by: Radhey Shyam Pandey <radhey.shyam.pandey@xilinx.com>
Link: https://lore.kernel.org/r/1571150904-3988-8-git-send-email-radhey.shyam.pandey@xilinx.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/xilinx/xilinx_dma.c

index 93471a6..41189b6 100644 (file)
@@ -1482,6 +1482,7 @@ static int xilinx_dma_reset(struct xilinx_dma_chan *chan)
 
        chan->err = false;
        chan->idle = true;
+       chan->desc_pendingcount = 0;
        chan->desc_submitcount = 0;
 
        return err;