OSDN Git Service

drm/gma: Remove calls to kmap()
authorIra Weiny <ira.weiny@intel.com>
Mon, 24 Jan 2022 01:54:05 +0000 (17:54 -0800)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Mon, 24 Jan 2022 16:02:43 +0000 (17:02 +0100)
kmap() is being deprecated and these instances are easy to convert to
kmap_local_page().

Furthermore, in gma_crtc_cursor_set() use the memcpy_from_page() helper
instead of an open coded use of kmap_local_page().

Signed-off-by: Ira Weiny <ira.weiny@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/20220124015409.807587-4-ira.weiny@intel.com
drivers/gpu/drm/gma500/gma_display.c
drivers/gpu/drm/gma500/mmu.c

index 99da311..60ba7de 100644 (file)
@@ -335,7 +335,7 @@ int gma_crtc_cursor_set(struct drm_crtc *crtc,
        struct psb_gem_object *pobj;
        struct psb_gem_object *cursor_pobj = gma_crtc->cursor_pobj;
        struct drm_gem_object *obj;
-       void *tmp_dst, *tmp_src;
+       void *tmp_dst;
        int ret = 0, i, cursor_pages;
 
        /* If we didn't get a handle then turn the cursor off */
@@ -400,9 +400,7 @@ int gma_crtc_cursor_set(struct drm_crtc *crtc,
                /* Copy the cursor to cursor mem */
                tmp_dst = dev_priv->vram_addr + cursor_pobj->offset;
                for (i = 0; i < cursor_pages; i++) {
-                       tmp_src = kmap(pobj->pages[i]);
-                       memcpy(tmp_dst, tmp_src, PAGE_SIZE);
-                       kunmap(pobj->pages[i]);
+                       memcpy_from_page(tmp_dst, pobj->pages[i], 0, PAGE_SIZE);
                        tmp_dst += PAGE_SIZE;
                }
 
index fe9ace2..a70b01c 100644 (file)
@@ -184,17 +184,17 @@ struct psb_mmu_pd *psb_mmu_alloc_pd(struct psb_mmu_driver *driver,
                pd->invalid_pte = 0;
        }
 
-       v = kmap(pd->dummy_pt);
+       v = kmap_local_page(pd->dummy_pt);
        for (i = 0; i < (PAGE_SIZE / sizeof(uint32_t)); ++i)
                v[i] = pd->invalid_pte;
 
-       kunmap(pd->dummy_pt);
+       kunmap_local(v);
 
-       v = kmap(pd->p);
+       v = kmap_local_page(pd->p);
        for (i = 0; i < (PAGE_SIZE / sizeof(uint32_t)); ++i)
                v[i] = pd->invalid_pde;
 
-       kunmap(pd->p);
+       kunmap_local(v);
 
        clear_page(kmap(pd->dummy_page));
        kunmap(pd->dummy_page);