OSDN Git Service

staging: rtl8723au: Do not call netdev_open23a() from cfg80211_rtw_change_iface()
authorJes Sorensen <Jes.Sorensen@redhat.com>
Sun, 25 May 2014 20:43:10 +0000 (22:43 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 25 May 2014 22:14:39 +0000 (15:14 -0700)
Calling open on the device when changing the interface type is wrong.
Let the stack call open at the right time.

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c

index f75a825..2bcdbe1 100644 (file)
@@ -1391,15 +1391,6 @@ static int cfg80211_rtw_change_iface(struct wiphy *wiphy,
        int ret = 0;
 
        DBG_8723A("%s(%s): call netdev_open23a\n", __func__, ndev->name);
-       if (netdev_open23a(ndev) != 0) {
-               ret = -EPERM;
-               goto exit;
-       }
-
-       if (_FAIL == rtw_pwr_wakeup(padapter)) {
-               ret = -EPERM;
-               goto exit;
-       }
 
        old_type = rtw_wdev->iftype;
        DBG_8723A("%s(%s): old_iftype =%d, new_iftype =%d\n",