OSDN Git Service

komeda: no need to check return value of debugfs_create functions
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 13 Jun 2019 13:28:06 +0000 (15:28 +0200)
committerLiviu Dudau <Liviu.Dudau@arm.com>
Wed, 19 Jun 2019 16:02:55 +0000 (17:02 +0100)
When calling debugfs functions, there is no need to ever check the
return value.  The function can work or not, but the code logic should
never do something different based on this.

Cc: "James (Qian) Wang" <james.qian.wang@arm.com>
Cc: Liviu Dudau <liviu.dudau@arm.com>
Cc: Brian Starkey <brian.starkey@arm.com>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: dri-devel@lists.freedesktop.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Liviu Dudau <liviu.dudau@arm.com>
drivers/gpu/drm/arm/display/komeda/komeda_dev.c

index e1aa58e..5a11898 100644 (file)
@@ -53,9 +53,6 @@ static void komeda_debugfs_init(struct komeda_dev *mdev)
                return;
 
        mdev->debugfs_root = debugfs_create_dir("komeda", NULL);
-       if (IS_ERR_OR_NULL(mdev->debugfs_root))
-               return;
-
        debugfs_create_file("register", 0444, mdev->debugfs_root,
                            mdev, &komeda_register_fops);
 }