OSDN Git Service

dt-bindings: sound: wm8994: Correct required supplies based on actual implementaion
authorKrzysztof Kozlowski <krzk@kernel.org>
Fri, 1 May 2020 13:35:34 +0000 (15:35 +0200)
committerMark Brown <broonie@kernel.org>
Fri, 1 May 2020 16:45:23 +0000 (17:45 +0100)
The required supplies in bindings were actually not matching
implementation making the bindings incorrect and misleading.  The Linux
kernel driver requires all supplies to be present.  Also for wlf,wm8994
uses just DBVDD-supply instead of DBVDDn-supply (n: <1,3>).

Reported-by: Jonathan Bakker <xc-racer2@live.ca>
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Link: https://lore.kernel.org/r/20200501133534.6706-1-krzk@kernel.org
Signed-off-by: Mark Brown <broonie@kernel.org>
Documentation/devicetree/bindings/sound/wm8994.txt

index 68cccc4..367b58c 100644 (file)
@@ -14,9 +14,15 @@ Required properties:
   - #gpio-cells : Must be 2. The first cell is the pin number and the
     second cell is used to specify optional parameters (currently unused).
 
-  - AVDD2-supply, DBVDD1-supply, DBVDD2-supply, DBVDD3-supply, CPVDD-supply,
-    SPKVDD1-supply, SPKVDD2-supply : power supplies for the device, as covered
-    in Documentation/devicetree/bindings/regulator/regulator.txt
+  - power supplies for the device, as covered in
+    Documentation/devicetree/bindings/regulator/regulator.txt, depending
+    on compatible:
+    - for wlf,wm1811 and wlf,wm8958:
+      AVDD1-supply, AVDD2-supply, DBVDD1-supply, DBVDD2-supply, DBVDD3-supply,
+      DCVDD-supply, CPVDD-supply, SPKVDD1-supply, SPKVDD2-supply
+    - for wlf,wm8994:
+      AVDD1-supply, AVDD2-supply, DBVDD-supply, DCVDD-supply, CPVDD-supply,
+      SPKVDD1-supply, SPKVDD2-supply
 
 Optional properties:
 
@@ -73,11 +79,11 @@ wm8994: codec@1a {
 
        lineout1-se;
 
+       AVDD1-supply = <&regulator>;
        AVDD2-supply = <&regulator>;
        CPVDD-supply = <&regulator>;
-       DBVDD1-supply = <&regulator>;
-       DBVDD2-supply = <&regulator>;
-       DBVDD3-supply = <&regulator>;
+       DBVDD-supply = <&regulator>;
+       DCVDD-supply = <&regulator>;
        SPKVDD1-supply = <&regulator>;
        SPKVDD2-supply = <&regulator>;
 };