OSDN Git Service

net: Fix an ignored error return from dm9051_get_regs()
authorYang Li <yang.lee@linux.alibaba.com>
Wed, 16 Feb 2022 01:45:07 +0000 (09:45 +0800)
committerJakub Kicinski <kuba@kernel.org>
Thu, 17 Feb 2022 04:47:52 +0000 (20:47 -0800)
The return from the call to dm9051_get_regs() is int, it can be
a negative error code, however this is being assigned to an unsigned
int variable 'ret', so making 'ret' an int.

Eliminate the following coccicheck warning:
./drivers/net/ethernet/davicom/dm9051.c:527:5-8: WARNING: Unsigned
expression compared with zero: ret < 0

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Link: https://lore.kernel.org/r/20220216014507.109117-1-yang.lee@linux.alibaba.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/davicom/dm9051.c

index 8436afa..6a2bcfb 100644 (file)
@@ -519,9 +519,9 @@ static int dm9051_map_init(struct spi_device *spi, struct board_info *db)
 static int dm9051_map_chipid(struct board_info *db)
 {
        struct device *dev = &db->spidev->dev;
-       unsigned int ret;
        unsigned short wid;
        u8 buff[6];
+       int ret;
 
        ret = dm9051_get_regs(db, DM9051_VIDL, buff, sizeof(buff));
        if (ret < 0)