OSDN Git Service

drm/i915/display: Add comment to a function that probably can be removed
authorJosé Roberto de Souza <jose.souza@intel.com>
Mon, 23 Dec 2019 01:06:54 +0000 (17:06 -0800)
committerJosé Roberto de Souza <jose.souza@intel.com>
Mon, 23 Dec 2019 17:26:45 +0000 (09:26 -0800)
This function is only called from port sync and it is identical to
what will be executed again in intel_update_crtc() over port sync
pipes.
If it is really necessary at least it deserves a better name and a
comment, leaving it to people working on port sync.

Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Manasi Navare <manasi.d.navare@intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20191223010654.67037-7-jose.souza@intel.com
drivers/gpu/drm/i915/display/intel_display.c

index f512e94..6683377 100644 (file)
@@ -14737,6 +14737,10 @@ static void intel_set_dp_tp_ctl_normal(struct intel_crtc *crtc,
        intel_dp_stop_link_train(intel_dp);
 }
 
+/*
+ * TODO: This is only called from port sync and it is identical to what will be
+ * executed again in intel_update_crtc() over port sync pipes
+ */
 static void intel_post_crtc_enable_updates(struct intel_crtc *crtc,
                                           struct intel_atomic_state *state)
 {