OSDN Git Service

isdn: mISDN: hfcpci: Replace GFP_ATOMIC with GFP_KERNEL in hfc_probe()
authorJia-Ju Bai <baijiaju1990@gmail.com>
Fri, 27 Jul 2018 02:39:06 +0000 (10:39 +0800)
committerDavid S. Miller <davem@davemloft.net>
Fri, 27 Jul 2018 04:20:52 +0000 (21:20 -0700)
hfc_probe() is never called in atomic context.
It calls kzalloc() with GFP_ATOMIC, which is not necessary.
GFP_ATOMIC can be replaced with GFP_KERNEL.

This is found by a static analysis tool named DCNS written by myself.

Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/isdn/hardware/mISDN/hfcpci.c

index 72a271b..ebb3fa2 100644 (file)
@@ -2220,7 +2220,7 @@ hfc_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
        struct hfc_pci  *card;
        struct _hfc_map *m = (struct _hfc_map *)ent->driver_data;
 
-       card = kzalloc(sizeof(struct hfc_pci), GFP_ATOMIC);
+       card = kzalloc(sizeof(struct hfc_pci), GFP_KERNEL);
        if (!card) {
                printk(KERN_ERR "No kmem for HFC card\n");
                return err;