OSDN Git Service

crypto: bfin_crc - Simplify use of devm_ioremap_resource
authorAmitoj Kaur Chawla <amitoj1606@gmail.com>
Mon, 4 Jul 2016 13:00:21 +0000 (18:30 +0530)
committerHerbert Xu <herbert@gondor.apana.org.au>
Tue, 5 Jul 2016 15:05:24 +0000 (23:05 +0800)
Remove unneeded error handling on the result of a call to
platform_get_resource when the value is passed to
devm_ioremap_resource.

The Coccinelle semantic patch that makes this change is as follows:

// <smpl>
@@
expression pdev,res,n,e,e1;
expression ret != 0;
identifier l;
@@

- res = platform_get_resource(pdev, IORESOURCE_MEM, n);
  ... when != res
- if (res == NULL) { ... \(goto l;\|return ret;\) }
  ... when != res
+ res = platform_get_resource(pdev, IORESOURCE_MEM, n);
  e = devm_ioremap_resource(e1, res);
// </smpl>

Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/bfin_crc.c

index 95b7396..10db7df 100644 (file)
@@ -588,11 +588,6 @@ static int bfin_crypto_crc_probe(struct platform_device *pdev)
        crypto_init_queue(&crc->queue, CRC_CCRYPTO_QUEUE_LENGTH);
 
        res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-       if (res == NULL) {
-               dev_err(&pdev->dev, "Cannot get IORESOURCE_MEM\n");
-               return -ENOENT;
-       }
-
        crc->regs = devm_ioremap_resource(dev, res);
        if (IS_ERR((void *)crc->regs)) {
                dev_err(&pdev->dev, "Cannot map CRC IO\n");