OSDN Git Service

scsi: qedf: remove redundant initialization of 'fcport'
authorColin Ian King <colin.king@canonical.com>
Tue, 6 Feb 2018 14:03:16 +0000 (14:03 +0000)
committerMartin K. Petersen <martin.petersen@oracle.com>
Wed, 14 Feb 2018 02:37:00 +0000 (21:37 -0500)
Pointer fcport is initialized with a value that is never read, it is
re-assigned a new value later on, hence the initialization is redundant
and can be removed.

Cleans up clang warning:
drivers/scsi/qedf/qedf_io.c:920:21: warning: Value stored to 'fcport'
during its initialization is never read

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Chad Dupuis <chad.dupuis@cavium.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/qedf/qedf_io.c

index b15e695..50a50c4 100644 (file)
@@ -917,7 +917,7 @@ qedf_queuecommand(struct Scsi_Host *host, struct scsi_cmnd *sc_cmd)
        struct qedf_ctx *qedf = lport_priv(lport);
        struct fc_rport *rport = starget_to_rport(scsi_target(sc_cmd->device));
        struct fc_rport_libfc_priv *rp = rport->dd_data;
-       struct qedf_rport *fcport = rport->dd_data;
+       struct qedf_rport *fcport;
        struct qedf_ioreq *io_req;
        int rc = 0;
        int rval;