OSDN Git Service

[media] mt9v032: fix uninitialized variable warning
authorHans Verkuil <hverkuil@xs4all.nl>
Tue, 28 Jul 2015 08:33:55 +0000 (05:33 -0300)
committerMauro Carvalho Chehab <mchehab@osg.samsung.com>
Tue, 11 Aug 2015 13:27:18 +0000 (10:27 -0300)
drivers/media/i2c/mt9v032.c: In function ‘mt9v032_probe’:
  CC [M]  drivers/media/i2c/s5k4ecgx.o
drivers/media/i2c/mt9v032.c:996:20: warning: ‘pdata’ may be used uninitialized in this function [-Wmaybe-uninitialized]
  if (pdata && pdata->link_freqs) {
                    ^

It can indeed be uninitialized in one corner case. Initialize to NULL.

Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
drivers/media/i2c/mt9v032.c

index 977f400..a68ce94 100644 (file)
@@ -882,7 +882,7 @@ static const struct regmap_config mt9v032_regmap_config = {
 static struct mt9v032_platform_data *
 mt9v032_get_pdata(struct i2c_client *client)
 {
-       struct mt9v032_platform_data *pdata;
+       struct mt9v032_platform_data *pdata = NULL;
        struct v4l2_of_endpoint endpoint;
        struct device_node *np;
        struct property *prop;