OSDN Git Service

diag: Check for diag glink handle on connect event
authorSreelakshmi Gownipalli <sgownipa@codeaurora.org>
Thu, 30 Mar 2017 17:01:03 +0000 (10:01 -0700)
committerGerrit - the friendly Code Review server <code-review@localhost>
Fri, 7 Apr 2017 20:38:18 +0000 (13:38 -0700)
Check for diag glink handle on receiving connect and
disconnect events from glink.

Change-Id: I049367ffa4fbab1b8b3585cf6d1b53760e7431a6
Signed-off-by: Sreelakshmi Gownipalli <sgownipa@codeaurora.org>
drivers/char/diag/diagfwd_glink.c

index 37f3bd2..2784cf7 100644 (file)
@@ -468,7 +468,7 @@ static void diag_glink_connect_work_fn(struct work_struct *work)
        struct diag_glink_info *glink_info = container_of(work,
                                                        struct diag_glink_info,
                                                        connect_work);
-       if (!glink_info || glink_info->hdl)
+       if (!glink_info || !glink_info->hdl)
                return;
        atomic_set(&glink_info->opened, 1);
        diagfwd_channel_open(glink_info->fwd_ctxt);
@@ -480,7 +480,7 @@ static void diag_glink_remote_disconnect_work_fn(struct work_struct *work)
        struct diag_glink_info *glink_info = container_of(work,
                                                        struct diag_glink_info,
                                                        remote_disconnect_work);
-       if (!glink_info || glink_info->hdl)
+       if (!glink_info || !glink_info->hdl)
                return;
        atomic_set(&glink_info->opened, 0);
        diagfwd_channel_close(glink_info->fwd_ctxt);