OSDN Git Service

spi: zynq-qspi: Fix missing spi_unregister_controller when unload module
authorAxel Lin <axel.lin@ingics.com>
Sun, 18 Aug 2019 09:51:13 +0000 (17:51 +0800)
committerMark Brown <broonie@kernel.org>
Tue, 20 Aug 2019 12:10:48 +0000 (13:10 +0100)
Use devm_spi_register_controller to fix missing spi_unregister_controller
when unload module.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
Acked-by: Michal Simek <michal.simek@xilinx.com>
Link: https://lore.kernel.org/r/20190818095113.2397-1-axel.lin@ingics.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-zynq-qspi.c

index c6bee67..d812a21 100644 (file)
@@ -695,7 +695,7 @@ static int zynq_qspi_probe(struct platform_device *pdev)
        ctlr->setup = zynq_qspi_setup_op;
        ctlr->max_speed_hz = clk_get_rate(xqspi->refclk) / 2;
        ctlr->dev.of_node = np;
-       ret = spi_register_controller(ctlr);
+       ret = devm_spi_register_controller(&pdev->dev, ctlr);
        if (ret) {
                dev_err(&pdev->dev, "spi_register_master failed\n");
                goto clk_dis_all;