OSDN Git Service

pcm: dshare: enable silence
authorAlexander Jahn <ajahn@de.adit-jv.com>
Fri, 30 Dec 2016 06:29:11 +0000 (11:59 +0530)
committerTakashi Iwai <tiwai@suse.de>
Mon, 2 Jan 2017 13:50:34 +0000 (14:50 +0100)
This issue depends on system load - if the process using dshare is
scheduled fast enough, then there is no noise. A delay of e.g >~2ms
produces hearable noise.

Reproduction with instrumented aplay(sleep every 100th period for a
given time):
During the sleep time of 2000000us (2s) the hardware plays old samples
in a loop before xrun is detected and recovered after the sleep.
This is resolved by placing it in silence, in case of dshare plugin.

Signed-off-by: Alexander Jahn <ajahn@de.adit-jv.com>
Signed-off-by: Andreas Pape <apape@de.adit-jv.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
src/pcm/pcm_direct.c

index f5d922f..0770abc 100644 (file)
@@ -1161,7 +1161,8 @@ int snd_pcm_direct_initialize_slave(snd_pcm_direct_t *dmix, snd_pcm_t *spcm, str
                return ret;
        }
 
-       if (dmix->type != SND_PCM_TYPE_DMIX)
+       if (dmix->type != SND_PCM_TYPE_DMIX &&
+           dmix->type != SND_PCM_TYPE_DSHARE)
                goto __skip_silencing;
 
        ret = snd_pcm_sw_params_set_silence_threshold(spcm, &sw_params, 0);