OSDN Git Service

usb: typec: STUSB160X should select REGMAP_I2C
authorRandy Dunlap <rdunlap@infradead.org>
Fri, 15 Oct 2021 01:36:09 +0000 (18:36 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 18 Oct 2021 15:07:28 +0000 (17:07 +0200)
REGMAP_I2C is not a user visible kconfig symbol so driver configs
should not "depend on" it. They should depend on I2C and then
select REGMAP_I2C.

If this worked, it was only because some other driver had set/enabled
REGMAP_I2C.

Fixes: da0cb6310094 ("usb: typec: add support for STUSB160x Type-C controller family")
Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: Amelie Delaunay <amelie.delaunay@st.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-usb@vger.kernel.org
Reviewed-by: Amelie Delaunay <amelie.delaunay@foss.st.com>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Link: https://lore.kernel.org/r/20211015013609.7300-1-rdunlap@infradead.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/typec/Kconfig

index a0418f2..ab480f3 100644 (file)
@@ -65,9 +65,9 @@ config TYPEC_HD3SS3220
 
 config TYPEC_STUSB160X
        tristate "STMicroelectronics STUSB160x Type-C controller driver"
-       depends on I2C
-       depends on REGMAP_I2C
        depends on USB_ROLE_SWITCH || !USB_ROLE_SWITCH
+       depends on I2C
+       select REGMAP_I2C
        help
          Say Y or M here if your system has STMicroelectronics STUSB160x
          Type-C port controller.