OSDN Git Service

watchdog: davinci: Handle return value of clk_prepare_enable
authorArvind Yadav <arvind.yadav.cs@gmail.com>
Tue, 6 Jun 2017 10:17:53 +0000 (15:47 +0530)
committerWim Van Sebroeck <wim@iguana.be>
Mon, 3 Jul 2017 09:02:38 +0000 (11:02 +0200)
clk_prepare_enable() can fail here and we must check its return value.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@iguana.be>
drivers/watchdog/davinci_wdt.c

index 0e731d7..1ba9ead 100644 (file)
@@ -173,7 +173,11 @@ static int davinci_wdt_probe(struct platform_device *pdev)
                return PTR_ERR(davinci_wdt->clk);
        }
 
-       clk_prepare_enable(davinci_wdt->clk);
+       ret = clk_prepare_enable(davinci_wdt->clk);
+       if (ret) {
+               dev_err(&pdev->dev, "failed to prepare clock\n");
+               return ret;
+       }
 
        platform_set_drvdata(pdev, davinci_wdt);