OSDN Git Service

ASoC: cs4265: Fix part number ID error message
authorFabio Estevam <festevam@denx.de>
Wed, 22 Dec 2021 14:19:19 +0000 (11:19 -0300)
committerMark Brown <broonie@kernel.org>
Wed, 29 Dec 2021 12:45:44 +0000 (12:45 +0000)
The Chip ID - Register 01h contains the following description
as per the CS4265 datasheet:

"Bits 7 through 4 are the part number ID, which is 1101b (0Dh)"

The current error message is incorrect as it prints CS4265_CHIP_ID,
which is the register number, instead of printing the expected
part number ID value.

To make it clearer, also do a shift by 4, so that the error message
would become:

[    4.218083] cs4265 1-004f: CS4265 Part Number ID: 0x0 Expected: 0xd

Signed-off-by: Fabio Estevam <festevam@denx.de>
Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Link: https://lore.kernel.org/r/20211222141920.1482451-1-festevam@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/cs4265.c

index cffd611..b890021 100644 (file)
@@ -611,8 +611,8 @@ static int cs4265_i2c_probe(struct i2c_client *i2c_client,
        if (devid != CS4265_CHIP_ID_VAL) {
                ret = -ENODEV;
                dev_err(&i2c_client->dev,
-                       "CS4265 Device ID (%X). Expected %X\n",
-                       devid, CS4265_CHIP_ID);
+                       "CS4265 Part Number ID: 0x%x Expected: 0x%x\n",
+                       devid >> 4, CS4265_CHIP_ID_VAL >> 4);
                return ret;
        }
        dev_info(&i2c_client->dev,