OSDN Git Service

media: si470x-i2c: add missed operations in remove
authorChuhong Yuan <hslester96@gmail.com>
Sun, 10 Nov 2019 06:28:15 +0000 (07:28 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 4 Jan 2020 12:34:15 +0000 (13:34 +0100)
[ Upstream commit 2df200ab234a86836a8879a05a8007d6b884eb14 ]

The driver misses calling v4l2_ctrl_handler_free and
v4l2_device_unregister in remove like what is done in probe failure.
Add the calls to fix it.

Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/media/radio/si470x/radio-si470x-i2c.c

index 9326439..f9e1768 100644 (file)
@@ -460,6 +460,8 @@ static int si470x_i2c_remove(struct i2c_client *client)
        video_unregister_device(&radio->videodev);
        kfree(radio);
 
+       v4l2_ctrl_handler_free(&radio->hdl);
+       v4l2_device_unregister(&radio->v4l2_dev);
        return 0;
 }