OSDN Git Service

Ignore errors from correction parameter query and config for M4v and H263 encoders
authorJames Dong <jdong@google.com>
Thu, 23 Sep 2010 00:37:42 +0000 (17:37 -0700)
committerJames Dong <jdong@google.com>
Thu, 23 Sep 2010 17:12:45 +0000 (10:12 -0700)
This feature is not essential for camcorder application

Change-Id: Id560632207dcf24fe361280ebe8178ea7332f22d

media/libstagefright/OMXCodec.cpp

index ac0db18..76c8870 100644 (file)
@@ -980,7 +980,10 @@ status_t OMXCodec::setupErrorCorrectionParameters() {
     status_t err = mOMX->getParameter(
             mNode, OMX_IndexParamVideoErrorCorrection,
             &errorCorrectionType, sizeof(errorCorrectionType));
-    CHECK_EQ(err, OK);
+    if (err != OK) {
+        LOGW("Error correction param query is not supported");
+        return OK;  // Optional feature. Ignore this failure
+    }
 
     errorCorrectionType.bEnableHEC = OMX_FALSE;
     errorCorrectionType.bEnableResync = OMX_TRUE;
@@ -991,7 +994,11 @@ status_t OMXCodec::setupErrorCorrectionParameters() {
     err = mOMX->setParameter(
             mNode, OMX_IndexParamVideoErrorCorrection,
             &errorCorrectionType, sizeof(errorCorrectionType));
-    CHECK_EQ(err, OK);
+    if (err != OK) {
+        LOGW("Error correction param configuration is not supported");
+    }
+
+    // Optional feature. Ignore the failure.
     return OK;
 }