show warning for invalid synopsis parts

diff --git a/php/WP_CLI/Dispatcher/Subcommand.php b/php/WP_CLI/Dispatcher/Subcommand.php
index 16d101e..45be83b 100644 (file)
--- a/php/WP_CLI/Dispatcher/Subcommand.php
+++ b/php/WP_CLI/Dispatcher/Subcommand.php
@@ -43,6 +43,15 @@ class Subcommand extends CompositeCommand {
                        return;
 
                $parser = new \WP_CLI\SynopsisValidator( $synopsis );
+
+               $cmd_path = implode( ' ', get_path( $this ) );
+               foreach ( $parser->get_unknown() as $token ) {
+                       \WP_CLI::warning( sprintf(
+                               "The `%s` command has an invalid synopsis part: %s",
+                               $cmd_path, $token
+                       ) );
+               }
+
                if ( !$parser->enough_positionals( $args ) ) {
                        $this->show_usage();
                        exit(1);

diff --git a/php/WP_CLI/SynopsisValidator.php b/php/WP_CLI/SynopsisValidator.php
index 4b62a36..90a7cb8 100644 (file)
--- a/php/WP_CLI/SynopsisValidator.php
+++ b/php/WP_CLI/SynopsisValidator.php
@@ -13,6 +13,12 @@ class SynopsisValidator {
                $this->spec = SynopsisParser::parse( $synopsis );
        }
 
+       public function get_unknown() {
+               return array_column( $this->query_spec( array(
+                       'type' => 'unknown',
+               ) ), 'token' );
+       }
+
        public function enough_positionals( $args ) {
                $positional = $this->query_spec( array(
                        'type' => 'positional',