OSDN Git Service

hwmon: (sht15) remove redundant check on status and send of status value
authorColin Ian King <colin.king@canonical.com>
Mon, 18 Sep 2017 14:45:48 +0000 (15:45 +0100)
committerGuenter Roeck <linux@roeck-us.net>
Mon, 30 Oct 2017 01:36:03 +0000 (18:36 -0700)
A previous commit removed bit or'ing into to the integer status
so now status is now always zero. This means that the non-zero check on
status and the sht15_send_status call will never occur; it is deadcode.
Clean this up by removing the dead code.

Detected by: CoverityScan CID#1456835 ("Logically dead code")

Fixes: aa7ab80c578c ("hwmon: (sht15) Root out platform data")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
drivers/hwmon/sht15.c

index 0e3e5f8..25d2834 100644 (file)
@@ -925,7 +925,6 @@ static int sht15_probe(struct platform_device *pdev)
 {
        int ret;
        struct sht15_data *data;
-       u8 status = 0;
 
        data = devm_kzalloc(&pdev->dev, sizeof(*data), GFP_KERNEL);
        if (!data)
@@ -1002,13 +1001,6 @@ static int sht15_probe(struct platform_device *pdev)
        if (ret)
                goto err_release_reg;
 
-       /* write status with platform data options */
-       if (status) {
-               ret = sht15_send_status(data, status);
-               if (ret)
-                       goto err_release_reg;
-       }
-
        ret = sysfs_create_group(&pdev->dev.kobj, &sht15_attr_group);
        if (ret) {
                dev_err(&pdev->dev, "sysfs create failed\n");