OSDN Git Service

greybus: loopback: symbolically define max wait time
authorAlex Elder <elder@linaro.org>
Tue, 12 May 2015 02:16:37 +0000 (21:16 -0500)
committerGreg Kroah-Hartman <gregkh@google.com>
Tue, 12 May 2015 17:25:14 +0000 (10:25 -0700)
Use a symbolic constant to define the maximum time (number of
milliseconds) to delay between initiated operations.

Signed-off-by: Alex Elder <elder@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
drivers/staging/greybus/loopback.c

index e1e40ea..f7538aa 100644 (file)
@@ -55,6 +55,7 @@ struct gb_loopback {
 #define        GB_LOOPBACK_TYPE_PING                           0x02
 #define        GB_LOOPBACK_TYPE_TRANSFER                       0x03
 
+#define GB_LOOPBACK_MS_WAIT_MAX                                1000
 #define GB_LOOPBACK_SIZE_MAX                           SZ_4K
 
 /* Define get_version() routine */
@@ -121,8 +122,8 @@ static DEVICE_ATTR_RW(field)
 static void gb_loopback_reset_stats(struct gb_loopback *gb);
 static void gb_loopback_check_attr(struct gb_loopback *gb)
 {
-       if (gb->ms_wait > 1000)
-               gb->ms_wait = 1000;
+       if (gb->ms_wait > GB_LOOPBACK_MS_WAIT_MAX)
+               gb->ms_wait = GB_LOOPBACK_MS_WAIT_MAX;
        if (gb->type > 2)
                gb->type = 0;
        if (gb->size > GB_LOOPBACK_SIZE_MAX)