OSDN Git Service

hwmon: (ibmpowernv, pwm-fan) Use of_property_present() for testing DT property presence
authorRob Herring <robh@kernel.org>
Fri, 10 Mar 2023 14:47:06 +0000 (08:47 -0600)
committerGuenter Roeck <linux@roeck-us.net>
Wed, 19 Apr 2023 14:08:31 +0000 (07:08 -0700)
It is preferred to use typed property access functions (i.e.
of_property_read_<type> functions) rather than low-level
of_get_property/of_find_property functions for reading properties. As
part of this, convert of_get_property/of_find_property calls to the
recently added of_property_present() helper when we just want to test
for presence of a property and nothing more.

Signed-off-by: Rob Herring <robh@kernel.org>
Link: https://lore.kernel.org/r/20230310144706.1542434-1-robh@kernel.org
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
drivers/hwmon/ibmpowernv.c
drivers/hwmon/pwm-fan.c

index 8e37247..594254d 100644 (file)
@@ -456,9 +456,9 @@ static int populate_attr_groups(struct platform_device *pdev)
                 */
                if (!of_property_read_string(np, "label", &label))
                        sensor_groups[type].attr_count++;
-               if (of_find_property(np, "sensor-data-min", NULL))
+               if (of_property_present(np, "sensor-data-min"))
                        sensor_groups[type].attr_count++;
-               if (of_find_property(np, "sensor-data-max", NULL))
+               if (of_property_present(np, "sensor-data-max"))
                        sensor_groups[type].attr_count++;
        }
 
index 83a347c..57928d2 100644 (file)
@@ -427,7 +427,7 @@ static int pwm_fan_of_get_cooling_data(struct device *dev,
        struct device_node *np = dev->of_node;
        int num, i, ret;
 
-       if (!of_find_property(np, "cooling-levels", NULL))
+       if (!of_property_present(np, "cooling-levels"))
                return 0;
 
        ret = of_property_count_u32_elems(np, "cooling-levels");