OSDN Git Service

mmc: sdhci-esdhc-imx: merge the same register check into one place
authorDong Aisheng <aisheng.dong@freescale.com>
Wed, 27 May 2015 10:13:26 +0000 (18:13 +0800)
committerUlf Hansson <ulf.hansson@linaro.org>
Mon, 1 Jun 2015 07:07:15 +0000 (09:07 +0200)
In esdhc_writel_le() function, there's duplicated checking of the same
register as follows:
"if (unlikely(reg == SDHCI_INT_ENABLE || reg == SDHCI_SIGNAL_ENABLE))".
Merge them into one and remove the duplicated one.

Signed-off-by: Dong Aisheng <aisheng.dong@freescale.com>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/mmc/host/sdhci-esdhc-imx.c

index ef290a5..0c89293 100644 (file)
@@ -313,6 +313,11 @@ static void esdhc_writel_le(struct sdhci_host *host, u32 val, int reg)
                        data |= ESDHC_CTRL_D3CD;
                        writel(data, host->ioaddr + SDHCI_HOST_CONTROL);
                }
+
+               if (val & SDHCI_INT_ADMA_ERROR) {
+                       val &= ~SDHCI_INT_ADMA_ERROR;
+                       val |= ESDHC_INT_VENDOR_SPEC_DMA_ERR;
+               }
        }
 
        if (unlikely((imx_data->socdata->flags & ESDHC_FLAG_MULTIBLK_NO_INT)
@@ -333,13 +338,6 @@ static void esdhc_writel_le(struct sdhci_host *host, u32 val, int reg)
                        }
        }
 
-       if (unlikely(reg == SDHCI_INT_ENABLE || reg == SDHCI_SIGNAL_ENABLE)) {
-               if (val & SDHCI_INT_ADMA_ERROR) {
-                       val &= ~SDHCI_INT_ADMA_ERROR;
-                       val |= ESDHC_INT_VENDOR_SPEC_DMA_ERR;
-               }
-       }
-
        writel(val, host->ioaddr + reg);
 }