OSDN Git Service

ice: Remove redundant and premature event config
authorDave Ertman <david.m.ertman@intel.com>
Tue, 16 Apr 2019 17:30:47 +0000 (10:30 -0700)
committerJeff Kirsher <jeffrey.t.kirsher@intel.com>
Wed, 29 May 2019 09:53:57 +0000 (02:53 -0700)
In the path for re-enabling FW LLDP engine, there is
a call to register for LLDP MIB change events.  This
call is redundant, in that the call to ice_pf_dcb_cfg
will already register the driver for these events.  Also,
the call as it stands now is too early in the flow before
before DCB is configured.

Remove the redundant call.

Signed-off-by: Dave Ertman <david.m.ertman@intel.com>
Signed-off-by: Anirudh Venkataramanan <anirudh.venkataramanan@intel.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
drivers/net/ethernet/intel/ice/ice_ethtool.c

index 77c98b1..9dde6dd 100644 (file)
@@ -1080,12 +1080,6 @@ static int ice_set_priv_flags(struct net_device *netdev, u32 flags)
                         * registration/init failed but do not return error
                         * state to ethtool
                         */
-                       status = ice_aq_cfg_lldp_mib_change(&pf->hw, false,
-                                                           NULL);
-                       if (status)
-                               dev_dbg(&pf->pdev->dev,
-                                       "Fail to reg for MIB change\n");
-
                        status = ice_init_pf_dcb(pf, true);
                        if (status)
                                dev_dbg(&pf->pdev->dev, "Fail to init DCB\n");