OSDN Git Service

iwlwifi: don't dump_stack() when we get an unexpected interrupt
authorEmmanuel Grumbach <emmanuel.grumbach@intel.com>
Sat, 5 Feb 2022 09:21:32 +0000 (11:21 +0200)
committerLuca Coelho <luciano.coelho@intel.com>
Fri, 18 Feb 2022 08:40:54 +0000 (10:40 +0200)
It is yet unclear if the WARNING really points to a real problem,
but for sure the stack dump doesn't help fixing it.
Just use a regular error print instead.

Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
Link: https://lore.kernel.org/r/iwlwifi.20220205112029.a79e733a12f7.I8189344294222be0589fa43cc70fdf38e3057045@changeid
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
drivers/net/wireless/intel/iwlwifi/pcie/rx.c

index 71db571..516b2e5 100644 (file)
@@ -1627,10 +1627,13 @@ irqreturn_t iwl_pcie_irq_rx_msix_handler(int irq, void *dev_id)
        if (WARN_ON(entry->entry >= trans->num_rx_queues))
                return IRQ_NONE;
 
-       if (WARN_ONCE(!rxq,
-                     "[%d] Got MSI-X interrupt before we have Rx queues",
-                     entry->entry))
+       if (!rxq) {
+               if (net_ratelimit())
+                       IWL_ERR(trans,
+                               "[%d] Got MSI-X interrupt before we have Rx queues\n",
+                               entry->entry);
                return IRQ_NONE;
+       }
 
        lock_map_acquire(&trans->sync_cmd_lockdep_map);
        IWL_DEBUG_ISR(trans, "[%d] Got interrupt\n", entry->entry);