OSDN Git Service

media: i2c: dw9768: simplify getting state container
authorKrzysztof Kozlowski <krzk@kernel.org>
Mon, 21 Sep 2020 16:23:29 +0000 (18:23 +0200)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Mon, 16 Nov 2020 09:31:11 +0000 (10:31 +0100)
The pointer to 'struct v4l2_subdev' is stored in drvdata via
v4l2_i2c_subdev_init() so there is no point of a dance like:

    struct i2c_client *client = to_i2c_client(struct device *dev)
    struct v4l2_subdev *sd = i2c_get_clientdata(client);

This allows to remove local variable 'client' and few pointer
dereferences.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/i2c/dw9768.c

index 45cdd92..8b8cb4b 100644 (file)
@@ -315,8 +315,7 @@ static int dw9768_release(struct dw9768 *dw9768)
 
 static int dw9768_runtime_suspend(struct device *dev)
 {
-       struct i2c_client *client = to_i2c_client(dev);
-       struct v4l2_subdev *sd = i2c_get_clientdata(client);
+       struct v4l2_subdev *sd = dev_get_drvdata(dev);
        struct dw9768 *dw9768 = sd_to_dw9768(sd);
 
        dw9768_release(dw9768);
@@ -328,8 +327,7 @@ static int dw9768_runtime_suspend(struct device *dev)
 
 static int dw9768_runtime_resume(struct device *dev)
 {
-       struct i2c_client *client = to_i2c_client(dev);
-       struct v4l2_subdev *sd = i2c_get_clientdata(client);
+       struct v4l2_subdev *sd = dev_get_drvdata(dev);
        struct dw9768 *dw9768 = sd_to_dw9768(sd);
        int ret;