OSDN Git Service

staging: goldfish: fix coding style.
authorHoang Tran <hoangtran.gwr@gmail.com>
Mon, 16 Jun 2014 07:18:37 +0000 (15:18 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 18 Jun 2014 22:01:35 +0000 (15:01 -0700)
Using an else following a break or return can unnecessarily
indent code blocks.

This patch fixes coding style reported by checkpatch.pl, a part
of eudyptula challenge.

Signed-off-by: Hoang Tran <hoangtran.gwr@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/goldfish/goldfish_audio.c

index cbd4567..a166424 100644 (file)
@@ -203,10 +203,10 @@ static int goldfish_audio_open(struct inode *ip, struct file *fp)
                                             AUDIO_INT_WRITE_BUFFER_2_EMPTY);
                AUDIO_WRITE(audio_data, AUDIO_INT_ENABLE, AUDIO_INT_MASK);
                return 0;
-       } else {
-               atomic_dec(&open_count);
-               return -EBUSY;
        }
+
+       atomic_dec(&open_count);
+       return -EBUSY;
 }
 
 static int goldfish_audio_release(struct inode *ip, struct file *fp)
@@ -223,8 +223,8 @@ static long goldfish_audio_ioctl(struct file *fp, unsigned int cmd,
        /* temporary workaround, until we switch to the ALSA API */
        if (cmd == 315)
                return -1;
-       else
-               return 0;
+
+       return 0;
 }
 
 static irqreturn_t goldfish_audio_interrupt(int irq, void *dev_id)