OSDN Git Service

gpio/rockchip: drop irq_gc_lock/irq_gc_unlock for irq set type
authorJianqun Xu <jay.xu@rock-chips.com>
Mon, 16 Aug 2021 01:21:35 +0000 (09:21 +0800)
committerLinus Walleij <linus.walleij@linaro.org>
Mon, 16 Aug 2021 23:01:50 +0000 (01:01 +0200)
There has spin lock for irq set type already, so drop irq_gc_lock and
irq_gc_unlock.

Reviewed-by: Heiko Stuebner <heiko@sntech.de>
Signed-off-by: Jianqun Xu <jay.xu@rock-chips.com>
Link: https://lore.kernel.org/r/20210816012135.1119234-1-jay.xu@rock-chips.com
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/gpio/gpio-rockchip.c

index b2be560..036b2d9 100644 (file)
@@ -406,7 +406,6 @@ static int rockchip_irq_set_type(struct irq_data *d, unsigned int type)
                irq_set_handler_locked(d, handle_level_irq);
 
        raw_spin_lock_irqsave(&bank->slock, flags);
-       irq_gc_lock(gc);
 
        level = rockchip_gpio_readl(bank, bank->gpio_regs->int_type);
        polarity = rockchip_gpio_readl(bank, bank->gpio_regs->int_polarity);
@@ -461,7 +460,6 @@ static int rockchip_irq_set_type(struct irq_data *d, unsigned int type)
        rockchip_gpio_writel(bank, level, bank->gpio_regs->int_type);
        rockchip_gpio_writel(bank, polarity, bank->gpio_regs->int_polarity);
 out:
-       irq_gc_unlock(gc);
        raw_spin_unlock_irqrestore(&bank->slock, flags);
 
        return ret;