OSDN Git Service

leds: apu: fix error message on probing failure
authorEnrico Weigelt <info@metux.net>
Mon, 22 Jul 2019 12:08:51 +0000 (14:08 +0200)
committerJacek Anaszewski <jacek.anaszewski@gmail.com>
Mon, 22 Jul 2019 19:57:28 +0000 (21:57 +0200)
The current error message on failed probing tends to be a bit
misleading. Fix it to tell exactly that an APU v1 was not found.

Signed-off-by: Enrico Weigelt <info@metux.net>
Acked-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Jacek Anaszewski <jacek.anaszewski@gmail.com>
drivers/leds/leds-apu.c

index 451cb9f..d794f49 100644 (file)
@@ -170,13 +170,9 @@ static int __init apu_led_init(void)
        struct platform_device *pdev;
        int err;
 
-       if (!dmi_match(DMI_SYS_VENDOR, "PC Engines")) {
-               pr_err("No PC Engines board detected\n");
-               return -ENODEV;
-       }
-       if (!(dmi_match(DMI_PRODUCT_NAME, "APU"))) {
-               pr_err("Unknown PC Engines board: %s\n",
-                               dmi_get_system_info(DMI_PRODUCT_NAME));
+       if (!(dmi_match(DMI_SYS_VENDOR, "PC Engines") &&
+             dmi_match(DMI_PRODUCT_NAME, "APU"))) {
+               pr_err("No PC Engines APUv1 board detected. For APUv2,3 support, enable CONFIG_PCENGINES_APU2\n");
                return -ENODEV;
        }